document dev="true" as sandbox

Question

document dev="true" as sandbox

janzheng opened this issue 6 years ago · comments

Hey, I think your wrapper is great! But could you document setting :dev="true" as setting env="sandbox"?
Or I would also suggest using :env="sandbox" or :env="production" in your wrapper to mimic the same language as the component.

Cheers!

Khoa Nguyen · Answer 1 · Tue Feb 06 2018 03:12:16 GMT+0800 (China Standard Time)

Hey,

Thanks for the suggestion! This definitely makes more sense. I'll publish the change soon.

Jan Z · Answer 2 · Thu Feb 08 2018 01:45:10 GMT+0800 (China Standard Time)

That was fast! Keep up the good work

…

On Mon, Feb 5, 2018 at 2:12 PM, Khoa Nguyen ***@***.***> wrote: Hey, Thanks for the suggestion! This definitely makes more sense. I'll publish the change soon. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADsHaAlR-eALKpkSWASSP3fwUF8OjeS7ks5tR1KQgaJpZM4R4LwQ> .