Modal Component

Question

Modal Component

nathanstilwell opened this issue 4 years ago · comments

Nathan Stilwell commented 4 years ago

Modal

Cockroach Core Components Candidate

A display component focusing the user's attention on interstitial information

Existing Components

Modal from cockroachdb/cockroach (based on Modal from AntD)
Modal from CockroachCloud (based on Modal from AntD)
CustomModal from cockroachdb/cockroach (based on Modal from AntD)

Anne Birzin · Answer 1 · Fri May 01 2020 03:39:10 GMT+0800 (China Standard Time)

For reference, below is a Figma link of the Modal audit which demonstrates examples of where modals appear across CockroachCloud and Admin UI:

Modal Audit

Lauren Barker · Answer 2 · Mon May 04 2020 23:25:36 GMT+0800 (China Standard Time)

I think we should consider using https://github.com/reactjs/react-modal for the modal functionality. Our current modals are not accessible and cannot be focused on by screen readers.