Giters

cockroachdb / pebble

RocksDB/LevelDB inspired key-value database in Go

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

TestLoadPrecedingKeys is flaky

RaduBerinde opened this issue · comments

commented 
2024-03-31T10:28:52.9908998Z === RUN   TestLoadPrecedingKeys
2024-03-31T10:28:52.9909145Z     key_manager_test.go:167: 
2024-03-31T10:28:52.9909649Z         	Error Trace:	/home/runner/work/pebble/pebble/metamorphic/key_manager_test.go:167
2024-03-31T10:28:52.9909869Z         	Error:      	"1" is not greater than "1"
2024-03-31T10:28:52.9910072Z         	Test:       	TestLoadPrecedingKeys

From https://github.com/cockroachdb/pebble/actions/runs/8497409966/job/23275957140

commented

Based on the comment, maybe this just needs to be GreaterOrEqual:

	// NB: We can't assert equality, because the original run may not have
	// ever used the max of the distribution.
	require.Greater(t, cfg2.writeSuffixDist.Max(), uint64(1))