Giters

cockroachdb / pebble

RocksDB/LevelDB inspired key-value database in Go

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

db: support empty virtual tables

RaduBerinde opened this issue · comments

commented

Things break if we ingest an external table that has no keys in the given range. I don't remember the exact failure but it was an incorrect result. I believe I tracked it down to some levelIter code that assumed that once we reached a file in the range, it will produce a key.

See:

pebble/metamorphic/ops.go

Line 949 in 9591f93

// Currently we don't support ingesting external objects that have no point

We should support this case because the API allows it, and since we don't open external files during ingest, we can't check for it before incorporating the virtual table.