Giters

cockroachdb / pebble

RocksDB/LevelDB inspired key-value database in Go

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

wal: TestFailoverWriter is flaky on windows

jbowens opened this issue · comments

commented 
2024-02-12T20:39:05.8678369Z         	Error Trace:	D:/a/pebble/pebble/wal/failover_writer_test.go:227
2024-02-12T20:39:05.8678908Z         	            				D:/a/pebble/pebble/wal/failover_writer_test.go:350
2024-02-12T20:39:05.8680212Z         	            				C:/Users/runneradmin/go/pkg/mod/github.com/cockroachdb/datadriven@v1.0.3-0.20230413201302-be42291fc80f/datadriven.go:117
2024-02-12T20:39:05.8681482Z         	            				C:/Users/runneradmin/go/pkg/mod/github.com/cockroachdb/datadriven@v1.0.3-0.20230413201302-be42291fc80f/datadriven.go:336
2024-02-12T20:39:05.8682748Z         	            				C:/Users/runneradmin/go/pkg/mod/github.com/cockroachdb/datadriven@v1.0.3-0.20230413201302-be42291fc80f/datadriven.go:341
2024-02-12T20:39:05.8684012Z         	            				C:/Users/runneradmin/go/pkg/mod/github.com/cockroachdb/datadriven@v1.0.3-0.20230413201302-be42291fc80f/datadriven.go:210
2024-02-12T20:39:05.8685272Z         	            				C:/Users/runneradmin/go/pkg/mod/github.com/cockroachdb/datadriven@v1.0.3-0.20230413201302-be42291fc80f/datadriven.go:183
2024-02-12T20:39:05.8686523Z         	            				C:/Users/runneradmin/go/pkg/mod/github.com/cockroachdb/datadriven@v1.0.3-0.20230413201302-be42291fc80f/datadriven.go:143
2024-02-12T20:39:05.8687815Z         	            				C:/Users/runneradmin/go/pkg/mod/github.com/cockroachdb/datadriven@v1.0.3-0.20230413201302-be42291fc80f/datadriven.go:116
2024-02-12T20:39:05.8688346Z         	            				D:/a/pebble/pebble/wal/failover_writer_test.go:175
2024-02-12T20:39:05.8689627Z         	            				C:/Users/runneradmin/go/pkg/mod/github.com/cockroachdb/datadriven@v1.0.3-0.20230413201302-be42291fc80f/datadriven.go:424
2024-02-12T20:39:05.8690928Z         	            				C:/Users/runneradmin/go/pkg/mod/github.com/cockroachdb/datadriven@v1.0.3-0.20230413201302-be42291fc80f/datadriven.go:435
2024-02-12T20:39:05.8692188Z         	            				C:/Users/runneradmin/go/pkg/mod/github.com/cockroachdb/datadriven@v1.0.3-0.20230413201302-be42291fc80f/datadriven.go:448
2024-02-12T20:39:05.8693495Z         	            				C:/Users/runneradmin/go/pkg/mod/github.com/cockroachdb/datadriven@v1.0.3-0.20230413201302-be42291fc80f/test_interface.go:27
2024-02-12T20:39:05.8693708Z         	Error:      	"0s" is not less than "0s"
2024-02-12T20:39:05.8693957Z         	Test:       	TestFailoverWriter/errors
2024-02-12T20:39:05.8694115Z --- FAIL: TestFailoverWriter (0.19s)
2024-02-12T20:39:05.8694351Z     --- FAIL: TestFailoverWriter/blocking (0.19s)
2024-02-12T20:39:05.8694568Z     --- FAIL: TestFailoverWriter/errors (0.00s)
commented 
  					require.Less(t, time.Duration(0), metrics.WriteThroughput.WorkDuration)

I think I've seen this before, the timer resolution is lower on Windows and you can get 0 if you measure something that's quick enough.