Can we please include `fullnameOverride` and `nameOverride` in the values.yaml?

[JesseBot]

Without fullnameOverride in your values.yaml in this repo, it sometimes can cause an error if a user tries to specify this and is using helm template (Argo CD does this, for instance).

it's reference here:

helm-charts/cockroachdb/templates/_helpers.tpl

Lines 1 to 42 in 9193c1f

 {{/* 
 Expand the name of the chart. 
 */}} 
 {{- define "cockroachdb.name" -}} 
 {{- default .Chart.Name .Values.nameOverride | trunc 56 | trimSuffix "-" -}} 
 {{- end -}} 
  
 {{/* 
 Create a default fully qualified app name. 
 We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). 
 If release name contains chart name it will be used as a full name. 
 */}} 
 {{- define "cockroachdb.fullname" -}} 
 {{- if .Values.fullnameOverride -}} 
     {{- .Values.fullnameOverride | trunc 56 | trimSuffix "-" -}} 
 {{- else -}} 
     {{- $name := default .Chart.Name .Values.nameOverride -}} 
     {{- if contains $name .Release.Name -}} 
         {{- .Release.Name | trunc 56 | trimSuffix "-" -}} 
     {{- else -}} 
         {{- printf "%s-%s" .Release.Name $name | trunc 56 | trimSuffix "-" -}} 
     {{- end -}} 
 {{- end -}} 
 {{- end -}} 
  
 {{/* 
 Create a default fully qualified app name for cluster scope resource. 
 We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). 
 If release name contains chart name it will be used as a full name with release namespace appended at the end. 
 */}} 
 {{- define "cockroachdb.clusterfullname" -}} 
 {{- if .Values.fullnameOverride -}} 
     {{- printf "%s-%s" .Values.fullnameOverride .Release.Namespace | trunc 56 | trimSuffix "-" -}} 
 {{- else -}} 
     {{- $name := default .Chart.Name .Values.nameOverride -}} 
     {{- if contains $name .Release.Name -}} 
         {{- printf "%s-%s" .Release.Name .Release.Namespace | trunc 56 | trimSuffix "-" -}} 
     {{- else -}} 
         {{- printf "%s-%s-%s" .Release.Name $name .Release.Namespace | trunc 56 | trimSuffix "-" -}} 
     {{- end -}} 
 {{- end -}} 
 {{- end -}} 

Setting this in values.yaml would also make it more clear for users who are verifying which parameters are available.

Thank you for your time and for maintaining this chart! :)

[JesseBot]

thank you!