Reinforcement to Pick
loayei opened this issue · comments
I just wanted to note that this is very prone to failing loot reinforcing since it borrows less than pure bulks when the value is set over 1.
and 1 puts us in square one of continuous failure
@coccoinomane
Maybe add a minimum battle point?
Hi @loayei , I’ve yet to encounter an error.
Set the value to 4 and TUS limit to 25.
Yeah its still borrowing 225 BP crabs. @nikohd12
That's probably because there are no Bulks in the tavern. Nonetheless, I do think it's still fine as a looter.
There are plenty of Bulks in the tavern am not sure where the issue is. But would it be possible to modify the code to borrow the nth crab based on price only without changing the specs of the crab?
I spend 10 minutes trying to loot lol for the bot to borrow a low bp crab and I end up losing. ffs :(
Even when reinforcement to pick is set to = "1". It still would not choose the highest BP crab all the time. I am checking on the UI of the crabada and there are plenty within the maxPrice I input.
Hello @loayei , thank you for your report!
I have checked and failed to reproduce the issue.
Plese try to follow these steps:
- Make sure you are on the latest commit of
master. - Make sure you are on the
HighestBpstrategy. - Run the following command:
python3 -m src.tests.strategies.reinforce.testMakeReinforceStrategy 25 1
The command will show you the highest-BP crab in the Tavern under 25 TUS. About 90% of the times I run the command, I get a crab with 237 BP, see below screenshot.
If you vary the second parameter from 1 to 4, then you will sometime see crabs with 225 BP, because you are choosing crabs farther below. This is equivalent to set REINFORCEMENT_TO_PICK=4.
Cheers,
Cocco
I will try it now.
If you don't mind me asking isn't getting a list of crabs sorted by bp and then price low to high is a better way.
Then choosing the 5 or 6th crab from that list?
rather than losing stats which can lead to a loss
@coccoinomane
If you don't mind me asking isn't getting a list of crabs sorted by bp and then price low to high is a better way.
This is exactly how we are doing it now. The strategy is very simple, please go have a look at HighestBpReinforceStrategy.py and play with the parameters.
@coccoinomane So i was playing around with the testing. As I am choosing reinforcement to pick as soon as I pass 4 stats go down as we mentioned before. But on the UI end on crabada there is over 8 pages of pure bulks.
Sorry for asking to much am just trying to understand why reinforcementToPick would skip all those pages.
I am leaving my maxTUS as 30 for testing so I don't think the price is the issue.
After a chat with @coinmasterlisting, which I thank, I pushed a new strategy which could be what you need, @loayei .
The strategy name is HighestBpHighCost.
Please checkout https://github.com/coccoinomane/crabada.py/tree/2022-04-02_high-cost-reinforce-strategy and let me know if it works for you 🙂
@coccoinomane Thanks a lot!
Exactly what I needed. getting 237 Bp all the time now even with pick up to 30.
👯 👯♂️
This strategy can in other words not need the delay since you can specify each team with a different pick and still guarantee the full 237 Bp. Great work again!
Thanks for the feedback @loayei !
Good to know about this interesting side effect of REINFORCEMENT_TO_PICK 💪