Linting (Diagnostics) doesn't work

Question

Linting (Diagnostics) doesn't work

mikeTWC1984 opened this issue 4 years ago · comments

mikeTWC1984 commented 4 years ago

System Details

Vim or NeoVim?: both
Version of Vim (run vim --version) or NeoVim (run nvim --version): Neovim 0.4.3
_Version of coc-powershell : 0.1.1
Operating System: linux
PowerShell version (in PowerShell: $PSVersionTable): 7

Issue Description

I'm installing coc-extensions on the plain containers (various OS). Looks like there is some issue with linting for coc-powershell and coc-omnisharp. Initially I thought it's some global coc-nvim issue, because linting didn't work with python extension either. However after installing msft python server it was fixed. Then I realized linting is working with my old coc-powershell fork (I think it was v0.73).
When I do CocInfo using latest coc-powershell/omnisharp I see additional output channel (cs and ps1). Using my old fork I only see one output channel (Powershell or omnisharp)

Expected Behaviour

Actual Behaviour

-- Description of what actually happens --

Tyler James Leonhardt · Answer 1 · Fri May 22 2020 08:05:49 GMT+0800 (China Standard Time)

It looks like it's unable to find PSScriptAnalyzer... in the integrated console, can you run:

gmo -list PSScriptAnalyzer

mikeTWC1984 · Answer 2 · Fri May 22 2020 11:56:41 GMT+0800 (China Standard Time)

You are right, the command return nothing, and after installing PSScriptAnalyzer I see linting again. Thanks! Is it a bug or feature though? I guess coc-powershell used to install this module automatically

Tyler James Leonhardt · Answer 3 · Fri May 22 2020 12:20:26 GMT+0800 (China Standard Time)

Hmm it should "just work" what's your $env:PSModulePath set to?

The last path should be a coc-powershell specific path and PSSA is supposed to be in that but I might have packaged it wrong.

mikeTWC1984 · Answer 4 · Fri May 22 2020 12:28:32 GMT+0800 (China Standard Time)

/root/.local/share/powershell/Modules:/usr/local/share/powershell/Modules:/opt/microsoft/powershell/7/Modules

mikeTWC1984 · Answer 5 · Fri May 22 2020 12:58:20 GMT+0800 (China Standard Time)

When I use the old fork I do see coc-powershell in PSModulePath indeed.

Tyler James Leonhardt · Answer 6 · Sat May 23 2020 02:56:13 GMT+0800 (China Standard Time)

hmm and that's from within the PowerShell Integrated Console, yes?

Tyler James Leonhardt · Answer 7 · Sat May 23 2020 02:58:48 GMT+0800 (China Standard Time)

On macOS, I have the correct path:

PS > $env:PSModulePath

  /Users/tyleonha/.local/share/powershell/Modules
:/usr/local/share/powershell/Modules
:/usr/local/microsoft/powershell/7/Modules
:/usr/local/Cellar/powershell-daily/7.1.0-daily.20200430/libexec/Modules
:/Users/tyleonha/.config/coc/extensions/node_modules/coc-powershell/PowerShellEditorServices

/Users/tyleonha/.config/coc/extensions/node_modules/coc-powershell/PowerShellEditorServices

mikeTWC1984 · Answer 8 · Sat May 23 2020 10:02:09 GMT+0800 (China Standard Time)

I just installed everything again on the new linux machine, I do see coc-powershell/PowerShellEditorServices in the psmodulepath now, but linting is not working. PSScriptAnalyzer is not in that folder. I do see it when I install my the old fork.

mikeTWC1984 · Answer 9 · Sat May 23 2020 10:05:11 GMT+0800 (China Standard Time)

This is what old extension has in this folder:
docs Plaster PowerShellEditorServices PowerShellEditorServices.VSCode PSScriptAnalyzer

The new one has only PowerShellEditorServices

mikeTWC1984 · Answer 10 · Sat May 23 2020 23:42:07 GMT+0800 (China Standard Time)

OK, somehow 2.1.0 release does not contain those extra modules
https://github.com/PowerShell/PowerShellEditorServices/releases/tag/v2.1.0

Tyler James Leonhardt · Answer 11 · Sat May 23 2020 23:58:25 GMT+0800 (China Standard Time)

Great find! I'll get that fixed

Tyler James Leonhardt · Answer 12 · Fri May 29 2020 08:13:37 GMT+0800 (China Standard Time)

This should be fixed now :)