Giters

coc-extensions / coc-powershell

PowerShellEditorService integration for coc.vim

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Consider bundling PowerShell Editor Services with coc-powershell

TylerLeonhardt opened this issue · comments

commented

All we need to do is include PSES as part of the files we want to go in the package.

Positives

  • offline use - fixes #32
  • instant first time start up
  • No more confusion if the user doesn’t have airline that says it’s downloading pses.
  • no more dependency on node-powershell

Negatives

  • larger package size
  • fixed to PSES version
  • locked in to stable (or Preview?) version of PSES… or need to be clever

Here’s what this would look like in PR form

commented

@yatli let me know what your opinion is 👍

commented

Options:

  • ship stable PSES and let folks opt-in for Preview which downloads the preview (this is what c++ vscode extension does today)
  • ship two extensions on npm: coc-powershell & coc-powershell-preview (this is what we do with vscode today)
  • ship stable and preview (probably not a good idea)