cncf / k8s-conformance

🧪CNCF K8s Conformance Working Group

Home Page:https://cncf.io/ck

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

AKS naming collision

lachie83 opened this issue · comments

It looks like in 1.13 conformance that the aks directory name (that was used by Azure Kubernetes Service) prior to 1.13 has now been used by Alauda Kubernetes (AKS).
Reference:

https://github.com/cncf/k8s-conformance/tree/master/v1.13/aks
https://github.com/cncf/k8s-conformance/tree/master/v1.12/aks
https://github.com/cncf/k8s-conformance/tree/master/v1.11/aks
https://github.com/cncf/k8s-conformance/tree/master/v1.10/aks

I suggest that we prefix the aks with the provider name: eg. azure-aks and alauda-aks.

cc @taylorwaggoner @jing2uo

That sounds reasonable. If you wouldn't mind opening a PR to do so, I'll approve.

Another approach is to reserve the namespace for the party who first used it. In this case renaming just ‘alauda-aks‘. That would be how I’d want to see our registration treated if this happened to us.

@dankohn @WilliamDenniss I actually prefer William's approach and have submitted a PR that implements that approach by moving the aks directory under v1.13 to alauda-aks. If we are all in agreement please feel free to merge

Hi @lachie83 , we can rename our directory as alauda-kubernetes. Could you update your PR to reflect this? Thanks.