Branch protection rules
BobyMCbobs opened this issue · comments
Today I added status badges for PRs, which you'll notice at the bottom of the PR
While certainly not a requirement, there is now the option to enable branch protection requiring select status checks to be passing before a PR is mergeable.
A pro is that nothing that is definitely not checked and passing can merge.
A con is that if an error were to occur with the bot and a PR was manually verified, it wouldn't be able merged.
Interested to hear thoughts.
Please close if not needed or desired.
@BobyMCbobs thanks! Just to clarify, say for example a company used a logo file that had the incorrect format, but I wanted to approve them anyway, I wouldn't be able to do so until they fixed the file format?
@taylorwaggoner, that is correct
Of course, at the same time, the bot should be updated to meet your criteria. So the bot could be updated to support the logo in whichever format.
Some branch protection rules have been added to this repo for the default branch:
- require approval of one
- @taylorwaggoner is able to bypass requirements
- require DCO check
Unsure about the current best way to ensure that the verify-conformance check is required only for conformance PRs, since some PRs for this repo are not submissions. I know with some Prow related job checks in Kubernetes infra, there's a generic check which is required but whether that passes depends on the state of other jobs which are not required.
Thank you for updating this @BobyMCbobs