"please close" for cmssw repo

Question

"please close" for cmssw repo

kpedro88 opened this issue 5 years ago · comments

I noticed that https://github.com/cms-sw/cms-bot/blob/master/cmsdist_merge_permissions.py has an option "please close" to close a cmsdist PR. Could this be added for L1s/L2s to close CMSSW PRs as well?

cmsbuild · Answer 1 · Mon Apr 01 2019 22:13:16 GMT+0800 (China Standard Time)

A new Issue was created by @kpedro88 Kevin Pedro.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

Malik Shahzad Muzaffar · Answer 2 · Mon Apr 01 2019 23:18:06 GMT+0800 (China Standard Time)

@kpedro88, cmsdist_merge_permissions.py is for cmsdist comp developers so that they can merge/close cmsdist PR released to cmsdist comp_* branches.

But if we want this feature for cmssw then we can add 'please close' command to cms-bot

Kevin Pedro · Answer 3 · Mon Apr 01 2019 23:21:36 GMT+0800 (China Standard Time)

Yes, that is what I meant.

Malik Shahzad Muzaffar · Answer 4 · Thu May 23 2019 15:05:15 GMT+0800 (China Standard Time)

cms-bot now recognize 'please close' command from L1/L2 and release managers
http://cms-sw.github.io/cms-bot-cmssw-cmds.html

Fabio Cossutti · Answer 5 · Thu May 23 2019 15:08:37 GMT+0800 (China Standard Time)

@smuzaffar this is additional on top of the native GitHub button, whose functionality is restricted, am I correct?

Malik Shahzad Muzaffar · Answer 6 · Thu May 23 2019 15:17:24 GMT+0800 (China Standard Time)

yes, "Close" button is only visible to those who have write/admin permission of the repo. This will allow L2's to also close PRs instead of waiting on one of administrators.