last.fm plugin seems to publish api key in the commit message?

Question

last.fm plugin seems to publish api key in the commit message?

carlosalonso opened this issue 12 years ago · comments

I tried to use the last.fm plugin, but when running flashbake -c the API call, including my API key is published as the 1st line of the commit message.

Ian Paul · Answer 1 · Sat Mar 18 2017 02:53:30 GMT+0800 (China Standard Time)

This comment is stale, but since it's here...I think an easy solution is to just delete the logging.info command on line 43. That's how it's being captured as far as I can tell. Is that okay with you @commandline or is there a better alternative?

Thomas Gideon · Answer 2 · Sat Mar 18 2017 03:45:28 GMT+0800 (China Standard Time)

Changing it to debug, I think, would be preferable.

Ian Paul · Answer 3 · Sat Mar 18 2017 05:03:02 GMT+0800 (China Standard Time)

Sounds good. Pull request sent.

Ian Paul · Answer 4 · Mon Aug 21 2017 17:01:04 GMT+0800 (China Standard Time)

bumping this for @commandline with a request to close as this is resolved.