[Bug] First time Git Installation error is misleading: The batch file cannot be found

[Mathieu Moreau]

Version Information

Cmder version: v1.3.25
Operating system: Windows 10

Cmder Edition

Cmder Full (with Git)

Description of the issue

I downloaded
https://github.com/cmderdev/cmder/releases/download/v1.3.25/cmder.zip

started it, in post installation:

'C:\WINDOWS\system32\drivers\etc\hosts' -> '/etc/hosts'
'C:\WINDOWS\system32\drivers\etc\protocol' -> '/etc/protocols'
'C:\WINDOWS\system32\drivers\etc\services' -> '/etc/services'
'C:\WINDOWS\system32\drivers\etc\networks' -> '/etc/networks'
The batch file cannot be found.
Creating user startup file: "C:\apps\cmder2\config\user_profile.cmd"
1 file(s) copied.

How to reproduce

No response

Additional context

No response

Checklist

• I have read the documentation.
• I have searched for similar issues and found none that describe my issue.
• I have reproduced the issue on the latest version of Cmder.
• I am certain my issues are not related to ConEmu, Clink, or other third-party tools that Cmder uses.

[Dax T Games]

What is the problem? This looks completely normal to me on an initial run. Including the The batch file cannot be found..

It should only happen one time on initial launch after downloading a new version.

[Mathieu Moreau]

The batch file cannot be found.
Can be misleading. could say no optional configuration was loaded.

[David Refoua]

I agree, we can make the error a bit more informational. Let's add this.

[Dax T Games]

I don't believe it is even in our control.

It is coming from Git for Windows first run batch file when it deletes itself and when it deletes itself it can't go back to itself therefore it says batch file not found.

All we do is run their file.

[David Refoua]

Hmm, you're completely right, it'd be interested to fiddle with their code to see if we can modify the behavior to hide the error message. For example, instead of deleting the file from itself, we can execute another batch file to replace the current running one, without using call to return to the one that is going to delete itself. Then, in the other file, it could delete the calle.

That's of course just a mental exercise more than anything else, I don't really believe it would be worth implementing.

With that said, the more important thing in my opinion is to improve the first time run experience by clearly relaying the expected sequence of events that is going to happen to the user, muting the clutter that is produced, and maybe even clearing the screen upon detecting a successful post setup by Git.

These are just some thoughts, but I've been meaning to add some enhancement that would address the first time setup, I guess I have to submit a PR to better explain and clarify what I mean by improvements to the first time setup. Nothing fancy but sure appreciated by newcomers.

Thanks, @daxgames for correcting my oversight, I'll add more information in another issue with my proposed changes in preparation for the next major release, which hopefully would align with your approval.