Custom atlantis.yaml functionality removed
Crevil opened this issue · comments
I'm looking into having custom atlantis.yaml configs for different servers and found this fork through a lengthy discussion on the topic in the upstream (runatlantis#310 (comment)).
This fork looked promising and I've made a POC using this but just found out that PR #22 actually removed the functionality implemented in #12.
Have you found another way of dealing with this or was this some kind of mistake with the upstream merge?
@Crevil
we experimented with a lot of new features, but in the end ended up just adding our GitHub team whitelist feature to our fork for security.
We added a few more features before, but once we got the latest code from the upstream, we just added gh-team-whitelist to it (so I would say removing the other features was on purpose since we wanted to maintain as few differences from the upstream as possible).
But you are welcome to add the features from our PRs to your own fork.
Namely, we use one repo per AWS account. Each AWS account represents a stage. Since we use this approach, the need for multiple atlantis.yaml files were eliminated.
Thanks for the replies. Makes good sense and it was kind of what I was expecting.
We are leaning more into that solution as well for now as other approaches gets complicated very quickly. 👍