Sidecar feature
ebcFlagman opened this issue · comments
We would use kowl behind the oauth2-proxy, because we haven't the need for the "business" feature to authenticate with roles and so on.
So my question is, will you support an additional container beside the deployment in the future?
I can create a Pull request when you haven't time/need to implement such a feature.
Hey @ebcFlagman ,
generally I'm of course absolutely fine with people using the oauth2-proxy in front of Kowl. I'm just not sure whether it makes sense to add this functionality to the chart, because this can end up in endless feature requests (e.g. one prefers to use pomerium over oauth2-proxy etc) and I will not be able to maintain this.
In short I believe something like a sidecar should not be part of this helm chart, but you should create your own flavour of this chart. I hope that this makes sense to you
I understand that you will not support all those variants. I think about something like Grafana did it. There you can configure an extraContainer as multiline string. So it would be "generic" for you.
extraContainers: |
- name: oauth2-proxy
mage: bitnami/oauth2-proxy
resources:
...
Yes that would be fine for me, feel free to submit the PR :).
@weeco Have you an idea when new PR could be accepted?
@weeco Can you make a release of this or should we wait for another fixes?