throughputlb is deprecated
ctlong opened this issue · comments
The throughputlb package uses the old grpc balancer, which was deprecated in a later version of gRPC (v1.30.0+). If we want to bump the grpc module in the future, we will have to rewrite our code to make use of the new google.golang.org/grpc/balancer package.
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.
The labels on this github issue will be updated when the story is started.
It appears that grpc-throughputlb was only added to the loggregator release to provide a slight speed boost to doppler and traffic controller gRPC connections. See cloudfoundry/loggregator#3 for more details.
If that is true, then perhaps we can just remove grpc-throughputlb, as the effort required to make it work with newer versions of gRPC appears high, and the speed gains it provides on any old versions of gRPC would likely be made up by upgrading to a newer version of gRPC.