Use supported envoy version >1.19.1

Question

Use supported envoy version >1.19.1

plowin opened this issue 2 years ago · comments

Patrick Lowin commented 2 years ago

Use supported envoy version >1.19.1

Summary

Hi,
in diego-release an unsupported version of envoy is used (1.19.1). It was last updated in Sep 2021 with this PR.

1.19 was archived in June 2022 and supported versions are 1.20 - 1.23 at the current point in time.

In another issue, it was targeted to enable auto-bumps, but the issue was closed.

Steps to Reproduce

cf ssh into an app container and find the envoy version with

$ /etc/cf-assets/envoy/envoy --version
/etc/cf-assets/envoy/envoy  version: a2a1e3eed4214a38608ec223859fcfa8fb679b14/1.19.1/Clean/RELEASE/BoringSSL

Diego repo

Directly in diego-release, files referenced here:
https://github.com/cloudfoundry/diego-release/pull/590/files

Environment Details

This is for all recent cf-deployments or diego-releases.

Possible Causes or Fixes (optional)

Bump to a supported version
Enable auto-bumping

Amelia Downs · Answer 1 · Sat Dec 10 2022 00:11:46 GMT+0800 (China Standard Time)

Thanks for bringing this up @plowin.

We have an "update-envoy-blob" job in our pipeline that should run every time it gets a new image. But it looks like it hasn't gotten a new image since dec 2021. I will add a bug to our backlog to investigate.

Patrick Lowin · Answer 2 · Fri Dec 16 2022 15:58:38 GMT+0800 (China Standard Time)

Thanks!
You are referring to some internal pipelines outside the ones around networking on the WG-concourse? At least, I could not find the job there

Amelia Downs · Answer 3 · Fri Dec 16 2022 23:24:06 GMT+0800 (China Standard Time)

Yes, it is a pipeline that the Diego approvers have access to. This work is currently prioritized.

Patrick Lowin · Answer 4 · Wed Jan 18 2023 17:39:30 GMT+0800 (China Standard Time)

Hi @ameowlia, do you know if the item was picked yet?

Amelia Downs · Answer 5 · Wed Jan 18 2023 22:14:56 GMT+0800 (China Standard Time)

Hi @plowin, we merged a bump yesterday! https://github.com/cloudfoundry/diego-release/pull/682/files

And even better, the automatic bump pipeline is working again.

Thanks for raising this issue!

Geoff Franks · Answer 6 · Wed Jan 25 2023 23:14:31 GMT+0800 (China Standard Time)

hey @plowin! We had to revert the bump above as it was incompatible with cflinuxfs3. The envoy binary we pull in isn't statically compiled against OS libraries and had libc issues. Fortunately 1.23.x still works, so we bumped back up to that version after the revert.

For the long term, we're looking at statically compiling the binary ourselves, or otherwise solving the cross-stack libc issue.