cloudflare / netjet

Express middleware to generate preload headers

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Images within noscript tags are sent in link header

jloh opened this issue · comments

I've noticed this after enabling the Preload option on my Ghost blog however when I have images within <noscript> tags they're sent in the link header. Example scenario is when adding Piwik tracking code.

Example html:

<noscript><p><img src="//stats.example.com/piwik.php?idsite=1" style="border:0;" alt=""/></p></noscript>

Results in:

link: <//stats.example.com/piwik.php?idsite=2>; rel=preload; as=image

Apologies if this is an issue with Ghosts implementation of netjet and not netjet itself, let me know if I should be opening an issue there!

I think this can be fixed by adding a match for noscript and skipping the rest of that tree, but I haven't yet tested this idea.