cloudflare / boringtun

Userspace WireGuard® Implementation in Rust

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Move to Mio/Tokio

Noah-Kennedy opened this issue · comments

There is no reason we should be rolling our own epoll and kqueue. Let's just migrate to tokio or mio.

I have some concerns about the amount of unsafe in here. Much of this is custom crap that can be ripped out and replaced easily.

Should we expect these changes in near future?

@zaid3tech yes, I don't have a set date to give you, but you should expect this soon.

Thanks : )

Is this still in the works? I'd love to see it implemented.

Yes, I just have had reduced bandwidth due to some other things.

Hi all,

I hope all is well. Question, is the plan to just to replace the custom events system with mio, or to use Tokio runtime task scheduling etc?

The plan is to use tokio.

Hi @Noah-Kennedy, I know that this work has been on the backlog for sometime now. Any information on where this stands. I ask because any contribution my be dependent on something that might significantly change based on this rework. :-)

Hi @Noah-Kennedy , I am trying to move to tokio. Can you create a tokio branch which I can submit PR to?

https://github.com/lz1998/wg-rs

I just wanted to check in on when the migration will be completed. FYI, I've reimplemented it using Tokio and hope that it could help with the migration: https://github.com/lodrem/wiretun