clevertech / boilerplate

Clevertech boilerplate for projects based on Docker, Node.js and React

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Problem with project names with dashes

gimenete opened this issue · comments

docker-compose has problems with project names with dashes.
docker/compose#869

One way to fix this is to just remove the dashes when the project name is replaced here: https://github.com/clevertech/boilerplate/blob/master/docker/run#L5

There's a script that clones the project and replaces the name of the project in multiple files: https://github.com/clevertech/boilerplate/tree/create-boilerplate-app

for docker/run it should remove the dashes

Could we change dashes to snake_case? (to keep the names clear)

Sure 👍 if that works

I ended up fixing it without having to sacrifice dashes... so it's still consistent. I'll push as soon as I have write permissions.
I did change some dashes with underscores though... the ones pertaining to db users and names. Since databases don't like hyphens in their names I figured it'd be best to use undersores

we should close this