switch history displayed as graph

Question

switch history displayed as graph

chdagenais opened this issue a year ago · comments

Since unit_of_measurement field was added to the switch class in bbddb49 , history graph for switches aren't displayed as intended.

My switch.RM3500ZB is now displaying an empty kWh graph instead of switch stauts history (on/off)

Per HA documentation , entity with unit_of_measurement defined is displayed as x/y graph, and entity without unit_of_measurement is displayed as a linear status graph.

Claude Gelinas · Answer 1 · Sat Mar 04 2023 01:32:37 GMT+0800 (China Standard Time)

Hi thank you for reporting this issue. I don't think that we need to remove completely unit_of_measurement as it could penalize other devices in the switch.py file.
I'll check to change device_type instead so it will be reported as a switch on/off

chdagenais · Answer 2 · Sat Mar 04 2023 01:46:27 GMT+0800 (China Standard Time)

Not sure if any switch (wall or control) in HA are expected to have a unit of measurement, as the state is bool on/off and doesn’t have unit. The choice of the unit value for a switch isn’t obvious too. unit_of_measurement is set as kWh for the RM3500zb, but why not ºC for the current temp, or W for instant power ?

Claude Gelinas · Answer 3 · Sat Mar 04 2023 03:08:12 GMT+0800 (China Standard Time)

I've created a branch https://github.com/claudegel/sinope-130/tree/unit
Please test switch.py
It should fix it and let me know.
For now there are no way to choose other value then state value so we cannot use ºC for the current temp or W for instant power. For the RM3500ZB the state is on/off. But I'm looking for a possibility to decide which value is displayed in the state. it would be interesting to have the flow level on valve equiped with flow meeter or the water temperature for the RM3500ZB

chdagenais · Answer 4 · Sat Mar 04 2023 03:18:34 GMT+0800 (China Standard Time)

I think the best course of action for displaying sensor value for these devices is to register them as devices with multiple entity (on/off, flow, temp…) or create separated entity (automatically from the addon or manually like the templates in the README to get power consumption in the energy dashboard . Pretty sure a switch (electric or or a water valve) in Home Assistant shouldn’t return a state different than on/off open/closed anyway

Claude Gelinas · Answer 5 · Sat Mar 04 2023 03:36:49 GMT+0800 (China Standard Time)

So did you test switch.py ?

Claude Gelinas · Answer 6 · Sat Mar 04 2023 08:47:01 GMT+0800 (China Standard Time)

Ok I've merged your PR into the unit branch and did a code review to fix changes for icon and class in switch.py and sensor.py.
Now the history is showing correctly for all of my switchs.
I'm gonna make a new release for this.

Thank you for your help and comments

chdagenais · Answer 7 · Mon Mar 06 2023 23:53:17 GMT+0800 (China Standard Time)

Sorry for the delay,
It's back to expected behaviour with 2.0.2 , thanks!

Claude Gelinas · Answer 8 · Tue Mar 07 2023 09:20:38 GMT+0800 (China Standard Time)

Thanks to you for reporting this issue. Now everything is fine