ui: Button "Sign In with GitHub to agree" causes confusion
srl295 opened this issue · comments
URL to the linked Repository or Organization
- any
Steps to reproduce the problem
- attempt to sign a CLA with metadata (custom fields)
What is the expected result?
- I would expect the custom fields to show up even before the user signs in, so they know what will be expected.
- I would expect the user would know they must login BEFORE they sign the CLA
What happens instead?
- only the "I accept … privacy policy" message shows up.
- The button "Sign In with GitHub to agree" makes users think that clicking that button actually signs the CLA
Any other information? (attach screenshot if possible)
![image](https://private-user-images.githubusercontent.com/855219/291406727-3da25111-9951-44fe-9b09-d1f55ffe66c1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0NTU4MjcsIm5iZiI6MTcxOTQ1NTUyNywicGF0aCI6Ii84NTUyMTkvMjkxNDA2NzI3LTNkYTI1MTExLTk5NTEtNDRmZS05YjA5LWQxZjU1ZmZlNjZjMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyN1QwMjMyMDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02ODAxZWE4ZTIwN2YwMjdhNjBiMWE0ODlkZDgxOTU0YzcxYmVhNDAyZmQ0ODNiZDExM2Q4ZDQ5YmZiNmVjNWY4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.X8m066pQxoQqbHpewIwPTLTym2AKXRJjq9EdlcA8aOE)
but once you click that button:
![image](https://private-user-images.githubusercontent.com/855219/291406843-b7bbb6ac-499b-47c8-a035-cbf907f8a6f8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0NTU4MjcsIm5iZiI6MTcxOTQ1NTUyNywicGF0aCI6Ii84NTUyMTkvMjkxNDA2ODQzLWI3YmJiNmFjLTQ5OWItNDdjOC1hMDM1LWNiZjkwN2Y4YTZmOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyN1QwMjMyMDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kY2JlNzI2ODNlN2ZmMmEyYjgzMjI1ZjUzMDM1MzE2ZWFlYTBkN2RmYmQzNmIwYzg2ODQ4ZDg3NjI4NjdjNzc4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.ueO_zcnkzBiWJtQ1W7oYKWrE7iAU1im326UoI4ymuKs)
Used browser and browser version?
any