ckolderup / postmarks

a single-user bookmarking website designed to live on the Fediverse

Home Page:https://postmarks.glitch.me

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Imported links that are then edited are sent to AP Outbox with escaped characters

jeffsikes opened this issue · comments

I imported a bunch of links today through the admin tool, and all worked as expected. They were imported, the system attempted to grab opengraph titles and descriptions. The entries were not federated, as expected.

However, later this evening I went back to edit them, and add tags. I wasn't expecting them to get federated since they didn't when first entered, but they did. (Should they?)

When postmarks imports opengraph data, it surrounds the description in quotes.

When the postmark entry is edited and prepared for delivery to the AP outbox, a line break is added between the linked title and the description, which is in quotes. Both the line break and the quotes get escaped and then display inaccurately in client apps.

So there are two issues to address:

  • Should imported items that get edited end up pushed to the AP outbox?
  • Correctly dealing with the line break and quotes included in imported bookmarks.
image