ckolderup / postmarks

I edited this bookmark: https://tomcasavant.glitch.me/bookmark/19 to correct "twee" to "tweet" and that doesn't seem to have been edited in the actual activity. I assume ActivityPub has some sort of 'edit' endpoint that needs to be hit or something?

Thanks for reporting-- this was working at some point (this switch case should handle it) but this code got heavily refactored a couple times in August/September, so probably without tests available something got broken.

postmarks/src/activitypub.js

Line 90 in 0522da2

    
           type: 'Create', // this should be 'Update' but Mastodon does weird things with Updates

Looks like there must have been problems w/ the update activity at some point and it was switched to create

oof, I wish I had documented more thoroughly what I was seeing there, because that seems like a mistake.

I'm not an expert on the Mastodon codebase but it appears that edits get broadcast as "Update" objects with a special array for the id and the to and cc set to the original post id, which is interesting:
https://github.com/mastodon/mastodon/blob/c86ad4566003f15f2f4f2499efd36f20b62737ab/app/workers/activitypub/status_update_distribution_worker.rb#L18-L28

That line has been in there for 9 months though so if it was working before I doubt that's what broke it, I'm not sure how mastodon interprets a 'create' notice on an object that already exists

Yeah, I mean I'm just working from memory at this point since that was a stage of the project where I was working on it entirely on my own and doing extremely slipshod manual QA. I can take a stab at reproducing doing things "the Mastodon way" and see if that gets interop fixed for now.

(Also once we can confirm it works, getting tests set up for some degree of reproducibility, which is actually on my todo list to scaffold this evening, as I finally have a free night at home)

Edited bookmark doesn't edit the activity