cjheath / geoip

The Ruby gem for querying Maxmind.com's GeoIP database, which returns the geographic location of a server given its IP address

Home Page:http://geoip.rubyforge.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Why is the latitude/longitude an empty string?

jameshfisher opened this issue · comments

What's going on with these lines?:

latitude = ''

longitude = ''

This seems rather unidiomatic - a better value would be nil. The occasional appearance of "empty string" coordinate components caused a bit of confusion for us!

The answers are lost in the mist of time, unfortunately, but I suspect the answer was in Feb 2005, when I wrote the first pure Ruby version matching Sean Chittendon's C extension. The longitude setting was definitely that way when I migrated from rubyforge.org to github in October 2007, see

longitude = ''