Giters

cjheath / geoip

The Ruby gem for querying Maxmind.com's GeoIP database, which returns the geographic location of a server given its IP address

Home Page:http://geoip.rubyforge.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Closing database file

evgenyneu opened this issue · comments

commented

I have not found a place where the file is closed in the code. If so - is it kept open deliberately?
I am doing GeoIP.new("GeoIP.dat") on each page request in Rails. If it opens the file but never closes on each page load, it will soon use all file descriptors in the system. Am I missing something?

commented

On 04/06/2012, at 6:11 PM, Evgeny Neumerzhitskiy wrote:

I have not found a place where the file is closed in the code. If so - is it kept open deliberately?

Yes.

I am doing GeoIP.new("GeoIP.dat") on each page request in Rails. It opens the file but never closes on each page load, it will soon use all file descriptors in the system. Am I missing something?

It's preferable if you use a singleton. GeoIP is thread safe.

commented

@cjheath, this is very convenient, thank you for explanation. I see you even have a multi-process support for sharing the db file descriptor. The io-extra is not mentioned in your gem dependencies. So I guess I need to install it on my Ubuntu server to make the inter-process sharing work. Is that correct?

commented

I pulled Eric Wong's commit that added io-extra support without trying to understand it. You can review the commit here:
391001a

There should be a gem dependency (for Ubuntu platform only, I suppose, but I haven't researched how to add such a conditional dependency. If you do, I'd appreciate a pull request). Otherwise a documentation change is in order, to at least document the capability.

Also, there was a close method added at this commit, but I haven't done the git bisect to find when and why it was removed:
0b0dc63
If necessary, it can be added again.

commented

Thank you. Adding a platform-specific gem dependency is explained here. I have never done it myself though.

Following your advice I decided to create single GeoIP object for each Rails process. Therefore I do not need the close method. And moreover, country lookup now works twice as fast, compared to the previous method of creating GeoIP for every web page request.