Add tests for related variables

Question

Add tests for related variables

denismaier opened this issue 4 years ago · comments

We will need tests that test for related variables. I think there are two possible ways:

add @related to the test: if variable="title" related="original"
add new test-conditions for each relation: if original-variable="title"

2 has the advantage that you can test for variables that are on different levels in the same test: if original-variable="title" variable="translator". And it's more concise than 1. Of course, this means one attribute fore each relation, and this will be slightly more messy when we add new relations. If we use the first approach we can just add new options to @related. (OTOH, there won't be 100 relations; maybe three to five or so.)

Denis Maier · Answer 1 · Mon Sep 07 2020 16:29:04 GMT+0800 (China Standard Time)

So, @bwiernik @bdarcus. In light of #375 should we use option 1 here as well? With the new conditions syntax we should be flexible enough.

Brenton M. Wiernik · Answer 2 · Mon Sep 07 2020 20:07:34 GMT+0800 (China Standard Time)

Yes. If a more complex test is needed, the element condition syntax can be used.

The only thing that neither option currently has is an ability to test for a specific relation itself. We could skip that (e.g., instead testing for one of various related variables) or also add a related-item="original" condition.

Denis Maier · Answer 3 · Mon Sep 07 2020 20:30:59 GMT+0800 (China Standard Time)

The only thing that neither option currently has is an ability to test for a specific relation itself. We could skip that (e.g., instead testing for one of various related variables) or also add a related-item="original" condition.

Yes, we should add something like this.
When would related-item="original" test true?
a) If the current item has an variables with related="original"
b) If the current item is an original item?

Or should we add tests for both?

Denis Maier · Answer 4 · Mon Sep 07 2020 22:06:14 GMT+0800 (China Standard Time)

Ok. It's now possible to test for related variables. (see the PR)

Brenton M. Wiernik · Answer 5 · Mon Sep 07 2020 22:17:56 GMT+0800 (China Standard Time)

I think we always orient ourselves around the base item. So, related-item="original" tests for the presence of an original relation.

The question of is a related item is handled by specifying @relation on the rendering element.

Denis Maier · Answer 6 · Mon Sep 07 2020 22:27:28 GMT+0800 (China Standard Time)

So, related-item="original" tests for the presence of an original relation.

Good. Technically, this tests true if there is any related variable? Or a certain number of them?

Brenton M. Wiernik · Answer 7 · Mon Sep 07 2020 23:30:47 GMT+0800 (China Standard Time)

It tests true if there is an "original" related item. It would test false if there is a "reviewed" related item but no "original" related item.

Denis Maier · Answer 8 · Mon Sep 07 2020 23:42:58 GMT+0800 (China Standard Time)

Not sure I understand. How will that look like in the data?
Anyway, I've updated the PR with a test to cover this (if has-relation)

Brenton M. Wiernik · Answer 9 · Mon Sep 07 2020 23:48:26 GMT+0800 (China Standard Time)

I'm not sure what the confusion is, so forgive me if I am on a tangent.

So, if an item looks like this:

id: base-item
title: Base item title
original:
  id: original-item
  title: Orginal item title

Then, has-relation="original" tests true but has-relation="reviewed" tests false. The text value of the has-relation test specifies the type of relation to look for.