citahub / cita-common

Libraries for CITA (https://github.com/citahub/cita)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add clippy support

u2 opened this issue · comments

  • cita-common-benches
  • cita-types
  • logger
  • panic_hook
  • worker
  • error
  • snappy
  • cita-directories
  • cita-crypto-trait
  • ethcore-bloom-journal
  • rlp
  • rlp_derive
  • authority_manage
  • pubsub_rabbitmq
  • pubsub_zeromq
  • pubsub_kafka
  • pubsub
  • blake2b
  • util
  • jsonrpc-types
  • cita-web3
  • hashable
  • cita-merklehash
  • db
  • cita-secp256k1
  • cita-ed25519
  • cita-sm2
  • cita-crypto
  • libproto
  • proof
  • tx_pool
  • jsonrpc-proto
  • engine

I think this issue should be waiting for #179 .

commented

I think this issue should be waiting for #179 .

So we can do this issue now?

I'm afraid not. Life is not perfect, especially rust.

IMHO, since this issue, it is too difficult to add CI, now. (We have to modify the generated codes in build.rs.)

commented

I'm afraid not. Life is not perfect, especially rust.

IMHO, since this issue, it is too difficult to add CI, now. (We have to modify the generated codes in build.rs.)

don't understand. does #180 can help?

commented

Going to do it first. So i will check the details and get some help form you tomorrow. @yangby-cryptape

I add clippy to CI (#209) and replace Travis CI by Circle CI (#210) to speed up.
But I skip to lint almost all packages, only keep one as an example.

Next, we can add lint check for each crate, one by one.

commented

I add clippy to CI (#209) and replace Travis CI by Circle CI (#210) to speed up.
But I skip to lint almost all packages, only keep one as an example.

Next, we can add lint check for each crate, one by one.

Cool