cirruslabs / macos-image-templates

i was about to report that the Xcode-download is broken, only to notice that you just submitted #121 :-)
then i was about to ask why manually download xcodes rather than doing a brew install xcodes, only to discover that this is also addressed in #121. sigh.

so finally here's two suggestions (hopefully not yet implemented!)

xcodes as a --select option that makes

macos-image-templates/templates/xcode.pkr.hcl

Line 86 in 0027171

"xcodes select ${var.xcode_version}",

obsolete
xcodes moves the .XIP file into Trash, so

macos-image-templates/templates/xcode.pkr.hcl

Line 85 in 0027171

"sudo rm -rf ~/Downloads/*",

is redundant
xcodes has a --empty-trash option, making

macos-image-templates/templates/xcode.pkr.hcl

Line 84 in 0027171

"sudo rm -rf ~/.Trash/*",

obsolete.

so I'd like to suggest to use this:

diff --git a/templates/xcode.pkr.hcl b/templates/xcode.pkr.hcl
index d6d7cde..6227b90 100644
--- a/templates/xcode.pkr.hcl
+++ b/templates/xcode.pkr.hcl
@@ -80,10 +80,7 @@ build {
       "source ~/.zprofile",
       "brew install xcodesorg/made/xcodes",
       "xcodes version",
-      "xcodes install ${var.xcode_version} --experimental-unxip --path /Users/admin/Downloads/Xcode_${var.xcode_version}.xip",
-      "sudo rm -rf ~/.Trash/*",
-      "sudo rm -rf ~/Downloads/*",
-      "xcodes select ${var.xcode_version}",
+      "xcodes install ${var.xcode_version} --experimental-unxip --path /Users/admin/Downloads/Xcode_${var.xcode_version}.xip --select --empty-trash",
       "xcodebuild -downloadAllPlatforms",
       "xcodebuild -runFirstLaunch",
     ]

Thank you for the info! Yeah, we can open a PR and apply your suggesting or if you want to be on the list of contributors, feel free to submit a PR yourself!

xcodes usage