circles-learning-labs / ecto_adapters_dynamodb

DynamoDB adapter for Elixir's Ecto Database layer.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Consider adding support for stream/5 (Ecto 3)

darrenklein opened this issue · comments

As of the initial alpha release with Ecto 3 support, 624bffb, we do not support stream/5 - stream/5 is a @callback that was implemented in Ecto 3 for Ecto.Adapter.Queryable, but it was not critical to making the upgrade from Ecto 2 to Ecto 3 support.

At the moment, we raise in the event that a user calls this method:

@impl Ecto.Adapter.Queryable
def stream(_adapter_meta, _query_meta, _query, _params, _opts) do
  # TODO - consider adding support for this?
  raise "#{inspect __MODULE__}.stream: #{inspect __MODULE__} does not currently support stream"
end

Is Ecto's concept of stream something that is conceptually appropriate to adapt for use in DynamoDB? If so, it should be addressed; otherwise, continuing to raise is probably fine.