RSI returns `NaN` array

Question

RSI returns `NaN` array

vivekmiyani opened this issue 2 years ago · comments

Vivek commented 2 years ago

Describe the bug

customRsi / rsi returns NaN array.

To Reproduce

Run:

customRsi(14, Array.from(Array(100).keys()))

Expected behavior

RSI should return expected results.

Vivek · Answer 1 · Thu Jun 23 2022 17:39:42 GMT+0800 (China Standard Time)

Loved this library but stuck at this point 😢

Onur Cinar · Answer 2 · Thu Jun 23 2022 23:55:30 GMT+0800 (China Standard Time)

Vivek, thank you for reporting this, let me take a quick look.

Onur Cinar · Answer 3 · Fri Jun 24 2022 00:18:15 GMT+0800 (China Standard Time)

It looks like a recently introduced bug. I have a fix. You will be able to check it with the latest on the master branch in few minutes. I can push a release tonight if you are consuming it directly from the npm.

Onur Cinar · Answer 4 · Fri Jun 24 2022 00:33:41 GMT+0800 (China Standard Time)

Release v1.0.8 comes with the fix.

Vivek · Answer 5 · Fri Jun 24 2022 01:21:51 GMT+0800 (China Standard Time)

Thanks @cinar for your quick response & fix. Also thanks for the tests! ❤️

Onur Cinar · Answer 6 · Fri Jun 24 2022 01:59:05 GMT+0800 (China Standard Time)

You're welcome!