cilynx / rtl88x2bu

rtl88x2bu driver updated for current kernels.

Home Page:http://www.wolfteck.com/2018/02/22/wsky_1200mbps_wireless_usb_wifi_adapter/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Kernel module is not built with a dkms package due to CONFIG_RTL8822BU not being defined

dleidert opened this issue · comments

Hi. I created a Debian -dkms package from your source for a Raspberry Pi-based project (latest Raspbian, arm64), and the module didn't build during installation. dkms said that it was unable to determine the module to build. When I debugged the issue, I found this:

https://github.com/cilynx/rtl88x2bu/blob/5.8.7.1_35809.20191129_COEX20191120-7777/Makefile#L2383-L2387

The obj-m variable would be necessary to let dkms know, that we are building whatever $(MODULE_NAME) holds. But CONFIG_RTL8822BU is not defined at this stage, and it is also only defined (and exported) a few lines later, and only in the elsepart of some condition you are using, so it cannot be defined at all in line 2383 IMHO. If I move the declaration up, everything works as expected. I'm honestly a bit perplexed here that other people have not yet stumbled into this issue because this seems like a legitimate bug to me.

This looks very odd, indeed. Would you like to create a PR and ping me afterwards?