Members required for customized toolbar are not exported
justin-hackin opened this issue · comments
Bug reports:
One can not follow the instructions provided here #134 for customizing toolbar because the toolbar code contains imports relative to the src directory of this project. This requires obscure workarounds so that the dependent project can build the source files of this project.
Features:
Although TOOL_PAN, TOOL_ZOOM_IN, TOOL_ZOOM_OUT, and fitToViewer are exported, ToolbarButton and the icons are not. A simple solution: export ToolbarButton and icon components.
Here's a PR #192
However, you might want to consider enabling custom icons as props since I think this is the most common use case and having to copy-paste the existing code is not DRY. Though, in my use case, I also wanted to remove the none tool and props could be provided for this as well.
PR released with v3.9.0
Thanks again for accepting the PR. You helped me to build this https://www.youtube.com/watch?v=_J6QBTSfmpU
Wow, your lanterns are awesome and great use of the pan zoom tool!
Thanks for sharing