Giters

chromiumembedded / cef

Chromium Embedded Framework (CEF). A simple framework for embedding Chromium-based browsers in other applications.

Home Page:https://bitbucket.org/chromiumembedded/cef/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix dangling ResourceRequest* in InterceptedRequestHandlerWrapper

magreenblatt opened this issue · comments

commented

Describe the bug
The current design of InterceptedRequestHandlerWrapper relies on dangling ResourceRequest* pointers, which is a violation of raw_ptr usage rules (see issue #3717, issue #3239). Refactor InterceptedRequestHandlerWrapper to fix this properly.

commented

We should stop binding |request| in MaybeLoadCookies and instead add a mechanism for retrieving it in ContinueWithLoadedCookies if the request is still valid. Maybe make it a raw_ptr<> member of RequestState.