chrisvxd / story2sketch

Convert Storybook into Sketch symbols 💎

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Allow options to be passed to Puppeteer

andrewshawcare opened this issue · comments

I'm using Docker in my project and receiving the following error:

[0619/122651.197333:ERROR:zygote_host_impl_linux.cc(89)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180.

I'd like to allow Puppeteer to be launched with the --no-sandbox argument. Ideally, this could be implemented in this line as:

this.browser = await puppeteer.launch(this.puppeteerOptions);

Where this.puppeteerOptions would be { args: ["--no-sandbox"] }

Any updates on this?

Sorry for the delay @andrewshawcare, have been away on holiday and for some reason not receiving email notifications.

I'll try and have a look into this for you. Passing properties via the story2sketch config sounds like a great idea.

Just saw your PR! Thanks. Will review that.