christophgysin / aws-sdk-js-v3

Modularized AWS SDK for JavaScript.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing import in node-http-handler

hlolli opened this issue · comments

Describe the bug

A clear and concise description of what the bug is.

on the branch "deno" there are these two imports
https://github.com/christophgysin/aws-sdk-js-v3/blob/v3.32.0-1/packages/node-http-handler/src/node-http-handler.ts#L4-L5

but are missing from the deno release
https://deno.land/x/aws_sdk@v3.32.0-1/node-http-handler/node-http-handler.ts

this causes symbol not found errors when using custom requestHandler.

I assume it should look like this

import {
  Agent as hAgent,
  request as hRequest,
  RequestOptions,
} from "https://deno.land/std@0.141.0/node/http.ts";
import {
  Agent as hsAgent,
  request as hsRequest,
} from "https://deno.land/std@0.141.0/node/https.ts";

note that RequestOptions is part of http and not https
ref:
https://deno.land/std@0.134.0/node/https.ts

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.