christinaa / rpi-open-firmware

Open source VPU side bootloader for Raspberry Pi.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Revert cleanups.

christinaa opened this issue · comments

A lot of the code that was removed was there for a good reason, one cleanup actually outright breaks the code. Can you please revert all the cleanup stuff or at least put it under #ifdefs if you want to have a minimal build, but do not randomly remove code.

Considering the fact that this is still in early stages, a lot of the code there was for the purpose of debugging and removing that is just counterproductive.

Thank you.

I reverted it for now, style changes are okay though I prefer explicit curly braces around single line ifs but that's down to personal preference. Biggest issue is taking chunks of code that are actually used to print debug information of varying importance or breaking mailbox code.