Giters

chrismytton / fancybox-rails

Use FancyBox with the Rails asset pipeline

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

New fancybox

mattgibb opened this issue · comments

commented

Hey hecticjeff,

Thanks for supplying this gem!

There's a new version of fancybox here:

http://fancyapps.com/fancybox/

I tried to fork the repository, include the new assets and submit a pull request, but there were a couple of failing tests and I didn't know how to fix them.

commented

Awesome, thanks for the heads up!

I'll check out your fork, once I've got the tests passing I'll release a new version.

commented

Oh, your fork has gone! Could you push it again so I could take a look?

commented

Hmmm, I'm a bit reluctant to update the fancybox-rails gem to use this new version of fancyBox as the license has changed. Previously it was under the same license as jQuery (GPL & MIT), but now the author has put 2.0 under creative commons, and you have to buy the commercial version.

I don't want people upgrading without realising the license has changed, and may no longer be suitable for their project.

What are your thoughts on this?

commented

I'm using your gem in a project, and I do understand you concerns.

Maybe Matt you can make a second gem for Fancybox2 and explain the reason to it in the ReadMe?

But definitely that an update on a so big licence change is something you might be careful of.

commented

I, too, would like to see a gem wrapper for Fancybox2. Having it as a second project or a branch of this one that has to be explicitly specified in the gemfile is ok with me.