chrislgarry / Apollo-11

Original Apollo 11 Guidance Computer (AGC) source code for the command and lunar modules.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Proof WAITLIST

wopian opened this issue · comments

Proof read transcribed code of WAITLIST against scans

Lines: 564
Page: 1117—1132 (15)

Reduced quality scans can be found here

Minor issues:

Page 1122, BZMF WAITP00H should be BZMF WAITPOOH Note the 0 vs O. (link)

The label is on page 1132 where WAITP00H DXCH WAITEXIT should be WAITPOOH DXCH WAITEXIT (link)

These seem to be corroborated by this source.

In the images compare the "WAITPOOH" to the O in "OVERFLOW HAS OCCURRED".

A similar issue occurs on page 1131 where both LONGP00H should be LONGPOOH (link).

The corresponding label is on page 1132 (link).

Page 1132, WAITP00H should be WAITPOOH (link)

Page 1132, P00DOO1 should be POODOO1 (link) - the corresponging label is on page 1384 (img link, code link). Note the use of the label is in the correct form (POODOO1).

These are the only issues I was able to find. I thought a discussion would be better than jumping into a PR - but please let me know if you agree and would like a PR.

Thanks!

Please do not use the HTML source code provided by Ibiblio - those files and this repo come from the same 2009 digitisation source. The images provided by Ibiblio are the only true source 👍

PRs are always welcome :)

Shall i pick this up and create a PR for the changes?

@zpeters go ahead!

commented

@zpeters are you still working on this issue ?. Can i pick this up ?

I have fallen behind lately. Please go ahead and pick this up

commented

I am working on this issue.

commented

Few observations here.
In line Link Just after the text ASSEMBLY (Line R0005) there are two -- which is not present in the original image Image

Like wise in page 1117 in the image there is only a single hyphen, but in case of code in github there are two hyphen present is this okay.

In Page 1118 in the line R069 there is hyphen present Image correspondingly the same is missing in
(Link)(https://github.com/chrislgarry/Apollo-11/blob/master/Luminary099/WAITLIST.agc#L110)

In page 1121 line 0124 Image I am not sure if its PRI035 or PR1035 . In the code it is displayed as PRI035 (Link)(https://github.com/chrislgarry/Apollo-11/blob/master/Luminary099/WAITLIST.agc#L187)

commented

@wopian Any comments here ?.

@r-sreesaran: Like wise in page 1117 in the image there is only a single hyphen, but in case of code in github there are two hyphen present is this okay.

These should be replaced by a single hyphen to match scans.

@r-sreesaran: In Page 1118 in the line R069 there is hyphen present Image correspondingly the same is missing in Link

The hyphen from scans should be added

@r-sreesaran: In page 1121 line 0124 Image I am not sure if its PRI035 or PR1035 . In the code it is displayed as PRI035

This occurs in other places with clearer scans which show its most likely PRIO35 (letter i, letter o) than PR1035 - in 1098 the I is printed clearly and the letter O is more square than the nearby zeroes (identical to the o in OCT)