Giters

chrislgarry / Apollo-11

Original Apollo 11 Guidance Computer (AGC) source code for the command and lunar modules.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Proof TRIM_GIMBAL_CNTROL_SYSTEM

wopian opened this issue · comments

commented

Proof read transcribed code of TRIM_GIMBAL_CONTROL_SYSTEM against scans

Lines: 622
Page: 1472—1485 (13)

Reduced quality scans can be found here

commented

I would like to give this a go

commented

Review completed. No discrepancies or issues.

commented

Typo in file name (CNTROL instead of CONTROL)

image

commented

There's some discrepancies with some equations in the comments (like line 136 ) and double dashes (--) instead of single dashes (-) among others from what I found with a cursory glance of a few pages

image
image

commented

Thank you for pointing this out. Will start looking at file names in addition to the other things I missed.

commented

i just realized that i failed to read CONTRIBUTING.md. Going to make sure and read this over. Thanks again for the feedback. This is a really fun project

commented

Typo in file name (CNTROL instead of CONTROL)

image

Could you point me to where this is located? Just curious where i need to look to confirm the correct file name. Thanks

commented

Typo in file name (CNTROL instead of CONTROL)
image

Could you point me to where this is located? Just curious where i need to look to confirm the correct file name. Thanks

First scanned page of each file (before 0001/R0001) - https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/1472.jpg

commented

added pr #756 hopefully everything looks okay