Proof POWERED_FLIGHT_SUBROUTINES

Question

Proof POWERED_FLIGHT_SUBROUTINES

wopian opened this issue 5 years ago · comments

James Harris commented 5 years ago

Proof read transcribed code of POWERED_FLIGHT_SUBROUTINES against scans

Lines: 447
Page: 1259—1267 (8)

Reduced quality scans can be found here

serialhex · Answer 1 · Wed Oct 07 2020 02:33:17 GMT+0800 (China Standard Time)

I'm going to attempt this one if no one else is.

Thor · Answer 2 · Thu Oct 08 2020 23:15:17 GMT+0800 (China Standard Time)

@serialhex how's it going?
if youre tired of proofreading, ill be happy to pick up where you left off. :)

Thor · Answer 3 · Fri Oct 09 2020 20:17:25 GMT+0800 (China Standard Time)

I just started looking through it, and noticed on page 1262, that the word TRANSFORMED is hyphenated in the original, and not in the code here.
I assume that is an acceptable difference?
since it's a comment anyway.

serialhex · Answer 4 · Fri Oct 09 2020 22:05:14 GMT+0800 (China Standard Time)

Hey, sorry I didn't get back to you @tcuc I don't have reliable internet access, so I need to plan my updates accordingly. As far as I know & understand, the code should be exactly like the transcript, including misspellings. At least that's how I've been working on it.

I should have this done by the weekend sometime, maybe Monday.

James Harris · Answer 5 · Sat Oct 10 2020 02:53:09 GMT+0800 (China Standard Time)

I just started looking through it, and noticed on page 1262, that the word TRANSFORMED is hyphenated in the original, and not in the code here.

This should be corrected to match the scans.

since it's a comment anyway.

The proofing is focused solely on the comments (for the most part)

Deleted user · Answer 6 · Mon Oct 12 2020 01:16:22 GMT+0800 (China Standard Time)

Is this still open? Is there something I can help with?

James Harris · Answer 7 · Mon Oct 12 2020 02:37:38 GMT+0800 (China Standard Time)

Is this still open? Is there something I can help with?

@serialhex is already working on this

serialhex · Answer 8 · Tue Oct 13 2020 00:02:24 GMT+0800 (China Standard Time)

@wopian Question: I'm almost done with my transcription, but I just noticed that a lot of the code uses spaces instead of (or with) tabs in some places. Such as this:

# lines 77-80
CDUTRIGS	CA	CDUX
		TS	CDUSPOT +4	# the whitespace is a space
		CA	CDUY
		TS	CDUSPOT

and

# lines 88-93, removed comments
TR*GL**P	MASK	SIX
		TS	TEM3
		INDEX	TEM3
		CA	CDUSPOT
		DXCH	MPAC
		DXCH	VBUF 	+4	# Whitespace is a space and then a tab

There's even this:

# lines 434-437
		DXCH	MPAC 	+3	# space-tab between "MPAC" and "+3"
		DDOUBL
		INDEX 	TEM1		# space-tab between "INDEX" and "TEM1"
		DXCH	10

I don't know enough about AGC assembly to know if this is significant, but I doubt it is. Should I remove these spaces? It looks like it wouldn't mess up the alignment of the code at all, even in the first example the tab would put the +4 in the same column.

Everything else is done, I'm just curious about this whitespace issue. Thank you!

James Harris · Answer 9 · Tue Oct 13 2020 07:53:33 GMT+0800 (China Standard Time)

I don't know enough about AGC assembly to know if this is significant, but I doubt it is. Should I remove these spaces? It looks like it wouldn't mess up the alignment of the code at all, even in the first example the tab would put the +4 in the same column.

Should be tabs only for the (uncommented) code itself