chrisgoddard / singer-discover

A simple utility to edit Singer-spec schemas in the command line.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

stream not getting selected element

sziolko opened this issue · comments

When running singer-discover (on tap-hubspot and on tap-jira) I find that the "selected": true does not get added at the top level of the stream.

If I select the stream "projects" from tap-jira I expect that the start of the json would be:

  "streams": [
    {
      "tap_stream_id": "projects",
      "key_properties": [
        "id"
      ],
      "schema": {
        "selected": true,
        "properties": {

What I do get is:

  "streams": [
    {
      "tap_stream_id": "projects",
      "key_properties": [
        "id"
      ],
      "schema": {
        "properties": {

so the streams.schema.selected doesn't exist.

The fields within each stream are getting set as selected as intended.

For me to get the two taps mentioned above to run I have to use the --properties argument rather than --catalog if that is a useful distinction in how singer-discover is determining where to add the "selected" element.

@sziolko I am not sure if this problem still exists but if it does I guess the problem is behind tap-jira or tap-hubspot and not behind singer-discover. The selected property should be used in the metadata section, not in the streams section according to the documentation. Older singer versions used it in the streams section.

I suggest to close this issue.