alloca.h is not standard

Question

alloca.h is not standard

aameen951 opened this issue 7 years ago · comments

Ameen Sayegh commented 7 years ago

../code/twitter.c(5): fatal error C1083: Cannot open include file: 'alloca.h': No such file or directory

chr v1.x · Answer 1 · Wed Jan 18 2017 15:08:48 GMT+0800 (China Standard Time)

I'm aware it's nonstandard, but what compiler + version is this?

Ameen Sayegh · Answer 2 · Wed Jan 18 2017 15:11:02 GMT+0800 (China Standard Time)

Im using MSVC 2015

chr v1.x · Answer 3 · Wed Jan 18 2017 15:11:38 GMT+0800 (China Standard Time)

Ah, this must be due to the change I just pushed. Seems MSVC and GCC/Clang provide it in different headers. I'll add a guard to check compiler version there. At the moment alloca is used several places where I don't have good alternatives that fit within my API constraints, so it's necessary to keep around.

Ameen Sayegh · Answer 4 · Wed Jan 18 2017 15:15:52 GMT+0800 (China Standard Time)

in MSVC it is already included in malloc.h _alloca

you can wrap the include with ifndef _MSC_VER

chr v1.x · Answer 5 · Wed Jan 18 2017 15:17:22 GMT+0800 (China Standard Time)

This is done and committed. Thanks for the feedback!