Missing user.css and user.js
martinvelez opened this issue · comments
In static/index.html, you include user.css. However, that file does not exist in this repo. Is it needed?
The same is true for user.js.
user.css and user.js are included so individual sites can override the defaults.
For examples, see: https://gist.github.com/risacher/7753727 and https://gist.github.com/risacher/7837761
Recommend close.
Maybe comment them out or include empty files with commented examples like your gist?
This threw me off too, as I would not expect to see 404 errors. I don't think too many developers need to be informed that they can add js/css to html.
If user.css and user.js were included as blank files, then package upgrades would constantly ask you if you want to keep your customized versions or overwrite with the package's versions. On the other hand, if the includes were not in the static/index.html, the same problem would arise with that file when you customize it to include your css.
Personally, I like the way Chris set this up. I think the 404 errors in the log actually is what inspired me to customize my tty.js configuration...
But I can see the other side. Maybe a slick solution would be to not include the files in the package, but create empty files at startup if they don't exist?
Ahhhh ok... Yeah I am new to node and I see what you are saying. If you get understand npm... you get how those files are dealt with. Makes sense to me.
If a common node user see the 404 they think... "Hey I could make my own!". Yeah I get that :)