chirpstack / chirpstack-fuota-server

FUOTA server which can be used together with ChirpStack Application Server.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing MultiCastPingSlotPeriod parameter for Class B device in fuota_server.go

heidimao opened this issue · comments

We ran into an this bug when testing fuota deployment with Class B device:
pingNB must be > 0
MicrosoftTeams-image (4)

The possible reason is that the MultiCastPingSlotPeriod parameter is missing in fuota_server.go
https://github1s.com/brocaar/chirpstack-fuota-server/blob/e049e20ec9711fdc6900dc569f2ccd57496bd466/internal/api/fuota_server.go#L25

The error is gone after adding the following line:
MulticastPingSlotPeriod: uint8(req.GetDeployment().MulticastPingSlotPeriod),
MicrosoftTeams-image (3)

commented

To add to this: The MulticastPingSlotPeriod is a uint8t in the definition, but it can be a value that goes up to 4096.