More modular CSS?

Question

More modular CSS?

lewisnyman opened this issue 10 years ago · comments

Hi,

Thanks for writing this plugin. I'm working on integrating it into Drupal core at the moment. https://drupal.org/node/2207383

One of the problems with implementation is that the hint.css contains a lot of "non-functional" styling that we have to override to get looking right with our themes. The Drupal project doesn't use Sass and it's not a good idea to start chopping up the CSS file for maintenance reasons.

If we can agree on a direction I'm happy to do the leg work. Does it make sense to compile a hint.base.css file that contains just the functional stuff without any fancy shadows etc?

Kushagra Gour · Answer 1 · Mon Jun 16 2014 04:29:39 GMT+0800 (China Standard Time)

Hey @lewisnyman That sounds like a good idea. Will certainly be useful when theming is not wanted in the library. I'll look into this and as a first step I'll compile a list of things which can be counted as 'theme' and thus removed from the base build.

Lewis Nyman · Answer 2 · Thu Jun 19 2014 15:02:00 GMT+0800 (China Standard Time)

Great! :) If it helps, I would probably file the following under theming:
hint-color-types.scss
hint-rounded.scss
hint-effects.scss

As well as a few minor .hint properties like text-shadow and box-shadow.

Kushagra Gour · Answer 3 · Mon Jun 23 2014 05:09:21 GMT+0800 (China Standard Time)

WIP branch:

Source: https://github.com/chinchang/hint.css/blob/add-a-base-build/src/hint.base.scss
Build: https://github.com/chinchang/hint.css/blob/add-a-base-build/hint.base.css

Will make the required build process changes next and update.

Lewis Nyman · Answer 4 · Wed Jun 25 2014 17:23:31 GMT+0800 (China Standard Time)

This is great :) So useful

Kushagra Gour · Answer 5 · Sun Jul 06 2014 20:16:10 GMT+0800 (China Standard Time)

@lewisnyman This is live in v1.3.3. You get extra hint.base.css and hint.base.min.css now :)