chinchang / hint.css

A CSS only tooltip library for your lovely websites.

Home Page:https://kushagra.dev/lab/hint/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Hint does not hide when aria-label is not present

minimih opened this issue · comments

This hides the Tooltip:
<a class="hint--left" aria-label="">Left</a>

This does not hide the Tooltip:
<a class="hint--top">Top</a>

could you please assign this task to me I would like to work upon it

@chinchang can you assign this to me. I will resolve it

@sureshkumarAQ you still up for fixing this?

@sureshkumarAQ you still up for fixing this?

Yeah chinchang !! could you please guide me a little bit where to start ? I`m not getting it properly.

@sureshkumarAQ The selectors in the hint-core.scss file will need tweaking. In case the aria-label is empty, the :after element doesn't show because of undefined content value (content: attr(aria-label)). But the :before shows because it has valid content: ''.
To fix this we should change the showing of :after and :before to only when aria-label isn't undefined or empty string.