Giters

chef / omnibus

Easily create full-stack installers for your project across a variety of platforms.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Old code exceptions in HealthCheck should likely be deleted

lamont-granquist opened this issue · comments

commented

omnibus/lib/omnibus/health_check.rb

Lines 353 to 358 in 8504044

when /^\s+libjvm.so/
next
when /^\s+libjava.so/
next
when /^\s+libmawt.so/
next

Those lines date back to the original code that Stephen Delano wrote and seem like they're subverting the health check in some way. They should probably be deleted. Then it should be validated that chef-server and automate and any other JVM-using apps still built correctly.

commented

Oh this might be because we don't build the JVM and ship binaries that violate omnibus containment principles and we decided that's acceptable?

If so it should probably get documented, and maybe those three things should be broken out into a CONSTANT value like the other whitelist (as its still called now) values.