Update checkstyle/jdk-11-groovy-git-mvn to use latest version of maven, git, and groovy

Question

Update checkstyle/jdk-11-groovy-git-mvn to use latest version of maven, git, and groovy

Vyom-Yadav opened this issue 2 years ago · comments

We aim to run groovy scripts in a docker container to utilize the latest groovy version.
Main repo issue: checkstyle/checkstyle#12646

File to be updated:

devops/docker/no-exception-build-image/jdk-11-groovy-git-mvn/Dockerfile

Shubham Raj · Answer 1 · Sun Mar 12 2023 02:11:22 GMT+0800 (China Standard Time)

Hi @Vyom-Yadav is this issue still live ?

Vyom Yadav · Answer 2 · Sun Mar 12 2023 02:14:25 GMT+0800 (China Standard Time)

Yes

…

On Sat, 11 Mar 2023, 11:41 pm Shubham Raj, ***@***.***> wrote: Hi @Vyom-Yadav <https://github.com/Vyom-Yadav> is this issue still live ? — Reply to this email directly, view it on GitHub <#763 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARTVXPK3CKANIR7ETC3JMK3W3S55LANCNFSM6AAAAAAT777X7Y> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Shubham Raj · Answer 3 · Sun Mar 12 2023 02:44:03 GMT+0800 (China Standard Time)

@Vyom-Yadav Can you guide me about this issue and what actually to work on.

Vyom Yadav · Answer 4 · Sun Mar 12 2023 02:49:11 GMT+0800 (China Standard Time)

You need to update https://github.com/checkstyle/contribution/blob/master/devops/docker/maven-build-image/jdk-8u162b12/Dockerfile to use the latest version of maven, git, and groovy.

Shubham Raj · Answer 5 · Tue Mar 14 2023 00:16:41 GMT+0800 (China Standard Time)

@Vyom-Yadav I have tried to update the packages in the above file, can you check that if it works.

Vyom Yadav · Answer 6 · Sun Mar 19 2023 04:04:41 GMT+0800 (China Standard Time)

@Shubhamrajgithub You need to create a pull request.

Roman Ivanov · Answer 7 · Fri Dec 01 2023 14:17:39 GMT+0800 (China Standard Time)

Did we addressed this issue in your latest container?

We did not updated groovy to latest , and we actually downgraded to older version , details at #810 (comment)

From that issue:

looks like we went to older version of groovy due to Ubuntu usage.

@nrmancuso , @relentless-pursuit, can you explain a bit more?

f059eb4#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R54 we downgraded 3.0.9 to 2.4.21

Nick Mancuso · Answer 8 · Fri Dec 01 2023 19:21:15 GMT+0800 (China Standard Time)

Since we are using Ubuntu, it was easier to use the version of groovy that is included; we needed to unblock maven version update in main repo. We can do a separate battle with custom groovy version in scope of this issue. We can do manual installation, or try to layer docker images if that is easier and doesn’t bloat the image.

Roman Ivanov · Answer 9 · Sat Dec 02 2023 00:11:46 GMT+0800 (China Standard Time)

https://circleci.com/developer/images/image/cimg/base

Software:
build-essential 12.9ubuntu3, curl 7.81.0, docker 24.0.6, docker-compose /usr/local/bin/docker-compose Docker Compose version v2.23.0 v2.23.0, dockerize v0.8.0, git 2.42.0, jq 1.6, ubuntu 22.04.3 LTS, wget 1.21.2

Looks like they stick with Ubuntu 22, lts.

Vyom Yadav · Answer 10 · Sat Dec 02 2023 10:58:59 GMT+0800 (China Standard Time)

I don't understand why we don't use official groovy image as base and just install maven on those? Won't that sort our problem?

Roman Ivanov · Answer 11 · Sat Dec 02 2023 11:18:49 GMT+0800 (China Standard Time)

We do not need latest groovy for sure :).

Vyom Yadav · Answer 12 · Sat Dec 02 2023 11:38:16 GMT+0800 (China Standard Time)

Let's close this issue then.